raytracing.github.io icon indicating copy to clipboard operation
raytracing.github.io copied to clipboard

Book 3.3.5: Function parameters are used inconsistently

Open dimitry-ishenko opened this issue 1 year ago • 5 comments

In Chapter 3.5 we can't seem to settle on which letter to use as a parameter for the CDF and keep switching between $x$ and $r$. This is not a big deal, just a bit disorienting. Here is a sample:

Screenshot from 2024-04-15 22-28-51

This also occurs throughout other parts of the book, but just happened to catch my attention here.

dimitry-ishenko avatar Apr 16 '24 03:04 dimitry-ishenko

Moving into the v4.0.0 milestone for consideration. We may or may not punt this for the actual v4.0.0 release, depending on our progress.

hollasch avatar Apr 16 '24 17:04 hollasch

Note that this flipping between $x$ and $r$ is also reflected in accompanying figures.

hollasch avatar Aug 21 '24 19:08 hollasch

I think the problem here is that unfortunately P(r) refers to the PDF of one function, while P(x) is used to refer to a different function.

hollasch avatar Aug 23 '24 21:08 hollasch

I think that just renaming all P(r) to P(x) would create more confusion.

hollasch avatar Aug 23 '24 21:08 hollasch

Another option maybe is to use a letter different from P for one of them? Just an idea.

dimitry-ishenko avatar Aug 24 '24 01:08 dimitry-ishenko