raytracing.github.io icon indicating copy to clipboard operation
raytracing.github.io copied to clipboard

[book 3][ch 6.1] Image doesn't match the settings

Open genmeblog opened this issue 2 years ago • 4 comments

When I change samples per pixel from 64 to 100 (as it is in listing 17) my image is still much noisier than Image 3. In my reimplementation 1000 gives the matching result.

genmeblog avatar Aug 09 '23 20:08 genmeblog

Rendered examples on my side (possibly buggy):

Image 2 is almost the same as in the book:

ch02b

Image 3, after changing samples per pixels to 100:

ch06a

Image 4, imperfect PDF

ch06c

Image 5, random_in_hemisphere, this is undefined in the book, btw. Anyway the result is strange...

ch06d

genmeblog avatar Aug 09 '23 22:08 genmeblog

This work should be accomplished as a result of #863.

hollasch avatar Feb 11 '24 00:02 hollasch

When I change samples per pixel from 64 to 100 (as it is in listing 17) my image is still much noisier than Image 3. In my reimplementation 1000 gives the matching result.

Maybe this is an old issue, but Chapter 6.1 now says to increase number of samples per pixel to 1000:

Let’s adjust some parameters for the Cornell box:

 int main() {
     ...
+    cam.samples_per_pixel = 1000;
     ...
 }

dimitry-ishenko avatar Apr 25 '24 16:04 dimitry-ishenko

The brighter image part is a dup of #1321. @hollasch this issue can technically be closed.

dimitry-ishenko avatar Apr 25 '24 16:04 dimitry-ishenko