mps
mps copied to clipboard
ANSI platform builds shouldn't link pthreads.
Since this isn't using threads or POSIX locks, the -lpthreads
should not be needed and having it only makes it easier to accidentally add some dependency on it.
[Edit by @rptb1 : @waywardmonkeys requires this change to build on WebAssembly. See #168 and #175 .]
It looks like the ANSI target is only tested on Travis CI (without digging deeply) and then we run into the same issue as the WebAssembly port where we're building threaded targets (some tests) in a single-threaded build.
It looks like the ANSI target is only tested on Travis CI (without digging deeply)
I'm working on design.mps.ci in #145 and will try to figure out the rationale for this.
JH+RB: essential as this is likely slowing down developers. Awaiting proc.review.express soon
Executing proc.review.express
- Start time 15:09.
- Entry criteria: entry.universal
- entry.universal.reason is false. Although @waywardmonkeys explained what the change was he doesn't explain why it's needed.
- Edited the original post to fix that.
- entry.universal.source-available is a bit tricky. Is it documented somewhere that WebAssembly platform does not provide pthreads?
- There is some stuff on the web which claims pthreads is supported for Emscripten. So the situation is unclear.
- Failing review entry until this situation is clarified.
- Procedure took 9 minutes.
I'll clarify what this is all about with @waywardmonkeys , who's the expert on the WebAssembly platform family.