Ravencoin icon indicating copy to clipboard operation
Ravencoin copied to clipboard

Update Rewards - specific distribution from address argument requested

Open lsji07 opened this issue 4 years ago • 2 comments
trafficstars

Current Reward RPC calls and associated arguments do not seem to allow the reward issuer to allocate a specific rvn address to issue rewards from as far as I can identify in the Rewards help section under calls. This may simply need updating.

== Rewards ==
cancelsnapshotrequest "asset_name" block_height
distributereward "asset_name" snapshot_height "distribution_asset_name" gross_distribution_amount ( "exception_addresses" ) ("change_address") ("dry_run")
getdistributestatus "asset_name" snapshot_height "distribution_asset_name" gross_distribution_amount ( "exception_addresses" )
getsnapshotrequest "asset_name" block_height
listsnapshotrequests ["asset_name" [block_height]]
requestsnapshot "asset_name" block_height

The situation I am looking at is where a single user who maintains and secures a single wallet and issues rewards. The ideal would be able to allocate a specific rvn address in the wallet to issue rewards from AND identify the current reward amount. This would maintain address balances and avoid draining specific preallocated addresses unintentionally. RVN in certain addresses in a users wallet may be for specific accounts or purposes and intentionally preallocated and not for funding reward transactions. I want to be able to direct rewards code to a specific address essentially to pull the funding from.

If this ability is existing, it is not shown in the console help section or elsewhere that I can find. Guidance would be appreciated.

lsji07 avatar Mar 23 '21 22:03 lsji07

The above requested feature of sending rewards from a specific RVN address is not currently a feature of the rewards code.

The way it is currently written is to use a standalone wallet dedicated to to issuing rewards, where any RVN address in that wallet can be used as required to pay the reward pro rata to token holders.

I would propose updating the rewards code to include the additional ability/argument to allow a wallet holder to specify a specific single RVN address in the wallet to pay rewards out from. Change and fees and so on are using the same address for simplicity as the identity of the issuer of a token is likely public already.

This would allow easier analytics for interested parties explorers to check token rewards history etc.

lsji07 avatar Mar 25 '21 20:03 lsji07

Issue has funding in https://rvn.cryptoscope.io/address/?address=RNwabkTSn877414W6SNKsgVY4fB5KR5eFZ bounty held by by Raven_Angels community. Contact Raven_Angels here https://discord.gg/SR3q2C8C. Donations welcome to support this specific issue by sending to the address above. RNwabkTSn877414W6SNKsgVY4fB5KR5eFZ

Any code pull request (PR) added for a bounty must include test units and include changes requested by the commenting and reviewing devs and community at large that improve the security and useability of the code within the scope of the issue. The dev creating the PR with all the above receives the bounty. That dev may share the bounty with whoever they choose.

lsji07 avatar Nov 25 '21 13:11 lsji07