Ravencoin icon indicating copy to clipboard operation
Ravencoin copied to clipboard

build, osx: Bip39: Add support multilanguage (#1085) breaks cross-compiling for OSX.

Open fdoving opened this issue 3 years ago • 4 comments

Commit in question: https://github.com/RavenProject/Ravencoin/commit/41a4d8b2c094ca9c55b11eed029a9817fa2b65d4

image

CXX wallet/libraven_wallet_a-bip39.o wallet/bip39.cpp:162:71: error: implicit instantiation of undefined template 'std::__1::array' std::array CMnemonic::GetLanguagesDetails() ^ /build/osx/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/usr/include/c++/v1/__tuple:223:64: note: template is declared here template struct _LIBCPP_TEMPLATE_VIS array; ^ wallet/bip39.cpp:164:12: error: implicit instantiation of undefined template 'std::__1::array' return {{ ^ /build/osx/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/usr/include/c++/v1/__tuple:223:64: note: template is declared here template struct _LIBCPP_TEMPLATE_VIS array; ^ 2 errors generated. Makefile:10246: recipe for target 'wallet/libraven_wallet_a-bip39.o' failed make[1]: *** [wallet/libraven_wallet_a-bip39.o] Error 1 make[1]: Leaving directory '/build/osx/src' Makefile:1286: recipe for target 'src/qt/raven-qt' failed make: *** [src/qt/raven-qt] Error 2 mv: cannot stat 'dist': No such file or directory make -C src qt/raven-qt make[1]: Entering directory '/build/osx/src' CXX wallet/libraven_wallet_a-bip39.o wallet/bip39.cpp:162:71: error: implicit instantiation of undefined template 'std::__1::array' std::array CMnemonic::GetLanguagesDetails() ^ /build/osx/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/usr/include/c++/v1/__tuple:223:64: note: template is declared here template struct _LIBCPP_TEMPLATE_VIS array; ^ wallet/bip39.cpp:164:12: error: implicit instantiation of undefined template 'std::__1::array' return {{ ^ /build/osx/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/usr/include/c++/v1/__tuple:223:64: note: template is declared here template struct _LIBCPP_TEMPLATE_VIS array; ^ 2 errors generated. Makefile:10246: recipe for target 'wallet/libraven_wallet_a-bip39.o' failed

fdoving avatar Nov 06 '21 08:11 fdoving

@henry-arcu89 ping, FYI.

fdoving avatar Nov 06 '21 08:11 fdoving

Ok, it seems that the error was that in OSX, it is necessary to add an include to import array.

With Ubuntu it compiled fine.

It would have to be tested with Windows as well.

henry-arcu89 avatar Nov 06 '21 09:11 henry-arcu89

With the include it builds for osx, linux and windows. github-checks build for linux and windows, so that is picked up.

https://github.com/fdoving/Ravencoin/releases/tag/v4.7.0test3-fdov

fdoving avatar Nov 06 '21 09:11 fdoving

Ok, great

henry-arcu89 avatar Nov 06 '21 09:11 henry-arcu89