Ravencoin icon indicating copy to clipboard operation
Ravencoin copied to clipboard

[GUI] Reissue asset does not allow to change unit

Open lorancecall opened this issue 3 years ago • 5 comments

This issue tracker is only for technical issues related to Ravencoin.

General Ravencoin questions and/or support requests and are best directed to the Ravencoin Discord).

For reporting security issues, please direct message one of the core developers in discord.

Describe the issue

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. In Raven-qt, select Manage Assets tap or right click asset from Overview then select 'Reissue Asset'
  2. The Unit was originally set as 8 but cannot change

Expected behaviour

Tell us what should happen I was expecting I can reduce the number of Unit with this function.

Actual behaviour

Tell us what happens instead The Unit field is activated, but cannot change value.

Screenshots.

If the issue is related to the GUI, screenshots can be added to this issue via drag & drop. Screen Shot 2021-05-31 at 10 52 27 AM

  • both clicking arrows and manually typing cannot change the value

What version of Ravencoin are you using?

List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA. v4.7.0.0-27dec57fc (64-bit)

Machine specs:

  • OS: OSX 11.4 (Big-Sur)
  • CPU: 2.9GHz Quad-Core Intel Core i7
  • RAM: 16 GB
  • Disk size: 500 GB
  • Disk Type (HD/SSD): SSD

Any extra information that might be useful in the debugging process.

This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

N/A

lorancecall avatar May 31 '21 14:05 lorancecall

https://github.com/RavenProject/Ravencoin/issues/984#issuecomment-851557194

This is designated situation, but might need to state somewhere in GUI (when reissue?)

lorancecall avatar May 31 '21 15:05 lorancecall

I agree.

fdoving avatar May 31 '21 16:05 fdoving

We've discussed this. It is possible to make an asset more divisible (if still reissuable), but not less, if there are code changes and it is adopted as a consensus rule.

The reason it can't become less divisible is that people might already own 0.00001, and if you made it non-divisible (units = 0) then what do you do with that person's asset holdings? Making it more divisible is a display issue, and 0.00001 becomes 0.00001000. All assets are integer values (of sats/corbies) at the base layer.

Another discussion took place that it would be possible to reduce the units (less-divisible) if the asset has never changed hands. This is trickier to code because it would require checking at multiple points (mempool, when adding a block, and reorgs) to make sure that no transfers have been made of the asset.

TronBlack avatar May 31 '21 17:05 TronBlack

Some kind of info to the user, when creating/reissuing, informing that it can only be increased would be nice. And simple.

fdoving avatar May 31 '21 18:05 fdoving

In case of sub-asset, when try to re-issue, the 'UNIT' field is not locked. The result does not change the unit, however, it would be good to make consistent with main asset.

Screen Shot 2021-06-01 at 9 16 04 AM

lorancecall avatar Jun 01 '21 13:06 lorancecall