Pushraven icon indicating copy to clipboard operation
Pushraven copied to clipboard

Singleton not thread safe

Open iamareebjamal opened this issue 8 years ago • 2 comments

The singleton pattern is prone to synchronization errors and is not thread-safe. If multiple thread mutate the state of Push Raven, it will lead to an inconsistent state. The library is really great and I would like to contribute in it after some discussion over design patterns are done

I think we can achieve simpler syntax with production level design with minimal impact on current API

iamareebjamal avatar Dec 28 '17 18:12 iamareebjamal

I am open to any suggestions, in fact the singleton implementation came about after issue #2

Raudius avatar Dec 29 '17 10:12 Raudius

Sure. I will add the proposed changes here soon

iamareebjamal avatar Dec 29 '17 11:12 iamareebjamal