090_adblock.conf stops DNS Masquerade service from starting.

[edalee]

Before submitting an issue Please read this first https://github.com/billz/raspap-webgui/wiki/Reporting-issues

• [x] This is a bug report
• [x] I searched existing issues before opening this one
• [x] I checked the FAQ before creating this issue
• [x] I have read and understand the issue reporting guidelines

Describe the bug 090_adblock.conf stops DNS Masquerade from starting. Having selected no to the Ad blocker on initial install and again when upgrading to latest version. The file 090_adblock.conf is installed in the /etc/dnsmasq.d/. This conf expects to files to be present on the file system:

conf-file=/etc/raspap/adblock/domains.txt
addn-hosts=/etc/raspap/adblock/hostnames.txt

However, they where never create when installing RaspAP. This in the latest version (656e5d8), subsequently stops the DNS Masquerade service from running.

Your environment

• Raspberry Pi hardware Pi 4 Model B
• Raspbian GNU/Linux 10 (buster)
• Y
• Y
• Quick Install
• Y
• N
• Onboard wireless chipset
• NordVPN client

Steps to reproduce Select no to Add Adblocker in install step (most likely version: 0801110) perhaps twice. The second no when upgrading to version: 656e5d8

Expected behavior All services required to run when starting RaspAP should start without errors no matter the set-up option.

Actual behavior

Nov 29 22:01:11 wifi systemd[1]: Starting dnsmasq - A lightweight DHCP and caching DNS server... Nov 29 22:01:11 wifi dnsmasq[1008]: dnsmasq: syntax check OK. Nov 29 22:01:11 wifi dnsmasq[1009]: dnsmasq: cannot read /etc/raspap/adblock/domains.txt: No such file or directory Nov 29 22:01:11 wifi dnsmasq[1009]: cannot read /etc/raspap/adblock/domains.txt: No such file or directory Nov 29 22:01:11 wifi dnsmasq[1009]: FAILED to start up Nov 29 22:01:11 wifi systemd[1]: dnsmasq.service: Control process exited, code=exited, status=3/NOTIMPLEMENTED Nov 29 22:01:11 wifi systemd[1]: dnsmasq.service: Failed with result 'exit-code'. Nov 29 22:01:11 wifi systemd[1]: Failed to start dnsmasq - A lightweight DHCP and caching DNS server.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Easily fix by: sudo rm /etc/dnsmasq.d/090_adblock.conf Or by commenting out the two lines in: sudo vi /etc/dnsmasq.d/090_adblock.conf thus:

# conf-file=/etc/raspap/adblock/domains.txt # addn-hosts=/etc/raspap/adblock/hostnames.txt

[billz]

Can you confirm that you a) ran the installer as normal (no -y, --yes or --assume-yes option), and b) used the -u switch to upgrade an existing install, again without the -y, --yes option? The file 090_adblock.conf is only added if accepted at the install prompt, or with the unattended install option.

[edalee]

First install in August was with this command: curl -sL https://install.raspap.com | bash. On the step/question Add adblocker (Beta) Y/N, n was submitted.

When upgrading – last week 30 Nov 2020 – this command: curl -sL https://install.raspap.com | bash -s -- -u. On the step/question Add adblocker (Beta) Y/N n was submitted.

[billz]

Did you capture the install log? The installer will report each step, including optional components that are skipped.

[edalee]

From the terminals stdout? Unfortunately not. I take it these are not by default persisted somewhere?

[billz]

It is now :) If you're able to repro this with log output that would be ideal. Otherwise I'll try to look into it.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Bassadin]

@billz I've got this "bug" too atm. My installation on a CM4 is not really old (a few weeks). Can you direct me where to get the logfiles so that I can help? I think it started happening once I tried updating RaspAP with the update flag. I should also mention that I'm trying to create a personal fork of RaspAP for my bachelor's thesis project, but I haven't changed much concerning the installation of dnsmasq yet.

Edit: I just added an empty file at /etc/raspap/adblock/domains.txt and now it's working again :D

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity.

[github-actions[bot]]

This issue was closed because it has been inactive for 14 days since being marked as stale.