rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Refactoring test methods

Open guilherme-mendes opened this issue 3 years ago • 6 comments

Proposed changes:

  • Apply clean code and unused imports test_actions.py
  • Implements uncouple behaviour from test_count_vectors_featurizer

guilherme-mendes avatar May 06 '21 17:05 guilherme-mendes

Thanks for submitting a pull request 🚀 @alopez will take a look at it as soon as possible ✨

sara-tagger avatar May 07 '21 06:05 sara-tagger

Thanks for the feedback @JEM-Mosig, changes made.

guilherme-mendes avatar May 13 '21 03:05 guilherme-mendes

Done! @JEM-Mosig @alopez

guilherme-mendes avatar May 14 '21 00:05 guilherme-mendes

Sorry, @guilherme-mendes I didn't see the message. I typically only see this when you click the re-review arrows and request another review. I'll have a look today :)

JEM-Mosig avatar Jun 17 '21 09:06 JEM-Mosig

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: guilherme-mendes
:x: itallogravina
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 09 '22 01:03 CLAassistant

@guilherme-mendes are you still intending to work on this? 🙂 if yes, please rebase onto main or merge main into your branch and see about all authors signing the CLA, then we're happy to review & approve it!

losterloh avatar Jun 01 '22 09:06 losterloh