rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Add better data input management for MS botframwork

Open thaume opened this issue 4 years ago • 7 comments
trafficstars

Proposed changes: As discussed in https://github.com/RasaHQ/rasa/issues/8164

We have been using this "feature" in production for 2 years now, I felt it was time to share it with everyone else using buttons in Teams' adaptive cards.

It's not a groundbreaking feature but it is very important.

I'll add the tests once we validate that we need this feature here :)

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [x] updated the changelog (please check changelog for instructions)
  • [x] reformat files using black (please check Readme for instructions)

thaume avatar Mar 12 '21 14:03 thaume

Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨

sara-tagger avatar Mar 15 '21 07:03 sara-tagger

@m-vdb PR fixed following your comments

thaume avatar Apr 22 '21 08:04 thaume

Awesome I've updated the docstring, taking care of the other steps now

thaume avatar Apr 22 '21 09:04 thaume

@m-vdb I updated everything, I'm just wondering about the tests : since there are none it seems a bit overkill (and I won't have time right now) to write all the tests for this channel, what do you think ?

In terms of documentation, there is no impact, it will just return a correct value everytime.

Let me know if you need me to change anything else

thaume avatar Apr 22 '21 09:04 thaume

@thaume following up on this one, do you need help to finalise the PR?

m-vdb avatar Jul 21 '21 08:07 m-vdb

@m-vdb hey ! I'll never find the time to wrap my head around the test strategy and write them myself. That's the main concern here 🙂

thaume avatar Jul 21 '21 08:07 thaume

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 07:04 stale[bot]