rasa
rasa copied to clipboard
Add better data input management for MS botframwork
Proposed changes: As discussed in https://github.com/RasaHQ/rasa/issues/8164
We have been using this "feature" in production for 2 years now, I felt it was time to share it with everyone else using buttons in Teams' adaptive cards.
It's not a groundbreaking feature but it is very important.
I'll add the tests once we validate that we need this feature here :)
Status (please check what you already did):
Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨
@m-vdb PR fixed following your comments
Awesome I've updated the docstring, taking care of the other steps now
@m-vdb I updated everything, I'm just wondering about the tests : since there are none it seems a bit overkill (and I won't have time right now) to write all the tests for this channel, what do you think ?
In terms of documentation, there is no impact, it will just return a correct value everytime.
Let me know if you need me to change anything else
@thaume following up on this one, do you need help to finalise the PR?
@m-vdb hey ! I'll never find the time to wrap my head around the test strategy and write them myself. That's the main concern here 🙂
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.