rasa
rasa copied to clipboard
implement functionality for 'rasa init' to interpret symbolic characters in project path creation such as '~'
Proposed changes:
NOTE this pull request will replace PR #7706 to circumvent CLA conflicts. Once this PR is accepted, I will close PR #7706
- implement os.path.expanduser on project creation path for correct functioning of '~' within path
- ensure other shortcut characters like '.' also function properly
Thanks to @hobson for discovering this issue and helping with the resolution along the way!
Status (please check what you already did):
Thanks for submitting a pull request 🚀 @kalkbrennerei will take a look at it as soon as possible ✨
Thanks for the review. It looks like the test I had in test_rasa_init.py was not testing the correct functionality. I'm currently flushing out that test.
@kalkbrennerei I've added the tests and reformatted using Black. I don't think this change requires updates to the docs, but please let me know if there's anything else I need to add - thanks!
Looking good @billy-horn , as @kalkbrennerei won't be able to reply soon, I can reply for them: no need to update the docs in this case and you already added have a changelog item ✅ would you be able to fix the conflict in the poetry.lock
file to get this PR merged? (also it sounds like the diff on this file is involuntary?). Thanks again for your contribution!
@m-vdb I'm not sure why there was a conflict with poetry.lock, but I've resolved it. Please let me know if there is anything else I can do for this PR. Thanks!
@m-vdb It's been a while, but is there any way to get this reviewed/approved?
Hi @billy-horn! It seems like the only thing left to do is to resolve the conflict in poetry.lock
. Is this something you want to do? Otherwise I can also jump in for help!
@kalkbrennerei Would you mind jumping in and fix the poetry.ock
so we can get this in?
Hey @wochinge! I didn't have time to do this before my vacation. Can you help out?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: billy-horn
:white_check_mark: kalkbrennerei
:x: Lydia Kalkbrenner
Lydia Kalkbrenner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@kalkbrennerei do you want to pick this one up again?