rasa icon indicating copy to clipboard operation
rasa copied to clipboard

`rasa init` misinterprets project path if it contains aliases such as '~'

Open hobson opened this issue 3 years ago • 12 comments

Rasa Version : 2.2.2 Rasa SDK Version : 2.2.0 Rasa X Version : None Python Version : 3.8.5 Operating System : Linux-5.4.0-60-generic-x86_64-with-glibc2.10 Python Path : /home/hobs/anaconda3/envs/rasaenv/bin/python

Issue: User in POSIX environment cannot use ~ shortcut (home directory) to create a rasa project in their home directory.

Error (including full traceback): There is no error message or traceback, only unexpected and incorrect behavior.

Command or request that led to error: N/A

$ rasa init ... ? Please enter a path where the project will be created [default: current direct ory] ~/rasaproject ...

Created project directory at '/home/hobs/code/tangibleai/rasa/~/rasaproject'.

Finished creating project structure. ? Do you want to train an initial model? 💪🏽 No No problem 👍🏼. You can also train a model later by going to the project directory and running 'rasa train'.

tangibleai/rasa$ ls ~/rasaproject ls: cannot access '/home/hobs/rasaproject': No such file or directory tangibleai/rasa$ ls -l total 572 drwxrwxr-x 3 hobs hobs 4096 Jan 10 16:15 '~' ...

Content of configuration file (config.yml) (if relevant): N/A

Content of domain file (domain.yml) (if relevant): N/A

submitted on behalf of @billy-horn who is submitting a PR that fixes it on @tangibleai 's fork

hobson avatar Jan 10 '21 22:01 hobson

Exalate commented:

sara-tagger commented:

Thanks for raising this issue, @m-vdb will get back to you about it soon

Please also check out the docs and the forum in case your issue was raised there too
🤗

sara-tagger avatar Jan 11 '21 07:01 sara-tagger

Exalate commented:

m-vdb commented:

Hi @hobson, thanks a lot for your bug report. It looks like a valid bug, since here we do not expand the user home directory.

You mentioned that @billy-horn was fixing it in a fork. In case you have some capacity, it would be great if you could submit a PR here. I'd happily take the review 😄

m-vdb avatar Jan 11 '21 08:01 m-vdb

Exalate commented:

guilherme-mendes commented:

Hey there, I would like to know if someone is already working on this issue.

guilherme-mendes avatar Mar 11 '21 21:03 guilherme-mendes

Exalate commented:

billy-horn commented:

This issue has been moved over to a new pull request that's being reviewed. I'll delete this one. Thanks!

billy-horn avatar Mar 11 '21 21:03 billy-horn

Exalate commented:

m-vdb commented:

@billy-horn do you have the link of the PR?

m-vdb avatar Mar 12 '21 07:03 m-vdb

Exalate commented:

billy-horn commented:

@m-vdb

Original PR: https://github.com/RasaHQ/rasa/pull/7706 We were having trouble with the CLA, so instead opened a new PR to circumvent the issue.

New PR: https://github.com/RasaHQ/rasa/pull/7790 This PR has been approved, but I have since added some tests to check the path expansion functionality.

I plan on closing #7706 but please let me know your thoughts.

billy-horn avatar Mar 12 '21 17:03 billy-horn

Exalate commented:

m-vdb commented:

great! yes please close the duplicate PR 🙏🏻

m-vdb avatar Mar 15 '21 15:03 m-vdb

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 21 '21 03:07 stale[bot]

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 09 '22 13:01 stale[bot]

Exalate commented:

sushii-00 commented:

Hello, i also would like to take a look at this issue, is it still open?

sushii-00 avatar Jan 26 '22 06:01 sushii-00

Exalate commented:

m-vdb commented:

Yes it is, there is a linked PR that appears to be stale at this stage, but could be good to look at for context 😄

m-vdb avatar Jan 31 '22 07:01 m-vdb

Is this issue still open for contribution? I am interested in solving it!

bielrossi15 avatar Jul 19 '22 16:07 bielrossi15

yes it is 😄

m-vdb avatar Oct 03 '22 07:10 m-vdb

➤ Maxime Verger commented:

:bulb: Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

:arrow_right: More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

sync-by-unito[bot] avatar Dec 19 '22 12:12 sync-by-unito[bot]

I want to work on it

AlvaroLeles avatar Dec 21 '22 20:12 AlvaroLeles