rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Published 20 hours ago • verified publisher icon RasaHQ

Feat #7487: Extract team id from slack event metadata and add to user…

Open kearnsw opened this issue 3 years ago • 4 comments

Changes are described in issue #7487.

Status (please check what you already did):

  • [X] added some tests for the functionality
  • [N/A] updated the documentation
  • [X] updated the changelog (please check changelog for instructions)
  • [X] reformat files using black (please check Readme for instructions)

kearnsw avatar Dec 08 '20 20:12 kearnsw

Thanks for submitting a pull request 🚀 @erohmensing will take a look at it as soon as possible ✨

sara-tagger avatar Dec 09 '20 07:12 sara-tagger

Thanks, Ella. That's odd, the tests passed on my local machine. I do see they failed on the requests that did not have a team field, but they only failed at the point which the metadata was referenced on the UserMessage. This means the get_metadata function successfully returned None for team_id. Are None valued metadata fields filtered out before being added to the UserMessage?

kearnsw avatar Dec 11 '20 13:12 kearnsw

Looks like the error on Windows Python 3.8 was not a result of this PR.

kearnsw avatar Dec 17 '20 04:12 kearnsw

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 07:04 stale[bot]