rasa icon indicating copy to clipboard operation
rasa copied to clipboard

fix empty messages when sending custom payload to socketio

Open santteegt opened this issue 4 years ago • 7 comments
trafficstars

Proposed changes:

  • Fixes socketio channel to avoid sending empty messages when a bot utterance contains a custom payload

Fixes #7344

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [ ] updated the changelog (please check changelog for instructions)
  • [X] reformat files using black (please check Readme for instructions)

santteegt avatar Nov 26 '20 01:11 santteegt

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 26 '20 01:11 CLAassistant

Thanks for submitting a pull request 🚀 @kalkbrennerei will take a look at it as soon as possible ✨

sara-tagger avatar Dec 01 '20 08:12 sara-tagger

@kalkbrennerei do you have time to take a look at this PR?

tmbo avatar Dec 07 '20 10:12 tmbo

@santteegt are you up for wrapping up this PR?

m-vdb avatar Mar 05 '21 14:03 m-vdb

Hi @m-vdb,

Yeah, however, I'm not sure if I should write unit tests for the changes I made as there are no existing unit tests for socketio channel. I was waiting for some direction here https://github.com/RasaHQ/rasa/pull/7373#discussion_r547562142

santteegt avatar Mar 05 '21 14:03 santteegt

I don't know much about this part of the codebase, but I think it'd be great if we could have a test that covers the change you're introducing, even if there's none today. If it requires a reasonable amount of work (that I can't tell for certain)

m-vdb avatar Mar 05 '21 14:03 m-vdb

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 07:04 stale[bot]