rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Add merge infos to MultiProjectImporter

Open neo-alex opened this issue 4 years ago • 8 comments

Proposed changes:

  • Add async caching to MultiProjectImporter (use cache to avoid re-loading & re-logging domain/stories/nlu/config)
  • Add logs for merging data (add actions/entities/forms/intents/slots merge infos in logs): this gives better insights to the user to make sure that the merges are intentional (cf. example below)

MergeExample

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [x] updated the changelog (please check changelog for instructions)
  • [x] reformat files using black (please check Readme for instructions)

neo-alex avatar Feb 19 '20 17:02 neo-alex

Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨

sara-tagger avatar Feb 20 '20 07:02 sara-tagger

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 24 '20 14:03 CLAassistant

@neo-alex How is it going? Can I help with the required changes?

wochinge avatar Mar 24 '20 16:03 wochinge

@wochinge Fine thanks, sorry for the delay - I will try to do required changes today and will let you know in case I need some help :)

neo-alex avatar Mar 26 '20 11:03 neo-alex

Alright, I tried to answer all your comments above with associated micro-commits. Let me know what you think when you get a chance to review again @wochinge Cheers

neo-alex avatar Mar 26 '20 18:03 neo-alex

@wochinge do you think this should be wrapped up and go into 2.0?

tmbo avatar Sep 26 '20 11:09 tmbo

@tmbo I don't think it's crucial for 2.0 and everybody has enough on their plate already. Will add it to my todo list anyway to make sure this gets wrapped up at some point.

wochinge avatar Sep 28 '20 09:09 wochinge

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 07:04 stale[bot]