rasa icon indicating copy to clipboard operation
rasa copied to clipboard

order of function call corrected. On similar lines of rasa-sdk

Open gajendrarao1979 opened this issue 11 months ago • 7 comments

Proposed changes:

  • ...

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [*] updated the changelog (please check changelog for instructions)
  • [*] reformat files using black (please check Readme for instructions)

gajendrarao1979 avatar Mar 13 '24 07:03 gajendrarao1979

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 13 '24 07:03 CLAassistant

Hi @gajendrarao1979, thank you for the pull request! Can you please describe the changes you've made and why are they required?

vcidst avatar Mar 25 '24 09:03 vcidst

@vcidst Currently in rasa main.py the configure_logging_and_warnings function which configures the logging from the config file is called at line 103 and after that configure_colored_logging is called at line 116.

The configure_colored_logging function leverages coloredlogs module which discards and reinitializes logging.StreamHandler. Essentially this overwrites any changes coming from logging.yml (if someone is using StreamHandler).

In my PR I have updated the order of the function call to ensure that logging.yml changes are not overwritten. This is already correct in rasa-sdk code.

I hope this provides the explanation.

image

gajendrarao1979 avatar Apr 16 '24 08:04 gajendrarao1979

@vcidst Any updates on this?

gajendrarao1979 avatar Jul 23 '24 06:07 gajendrarao1979

Necessary change for using on a production system where observability matters. Hoping to see this PR merged soon!

pdelagrave avatar Sep 25 '24 18:09 pdelagrave

Hey @gajendrarao1979, we won't be able to merge these PRs as this repository isn't under active maintenance anymore. Please see this page for our product releases and maintenance policy

vcidst avatar Sep 27 '24 12:09 vcidst