rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Add Spacy Italian pre-trained model into Rasa Docker image

Open ibaylyak opened this issue 3 years ago • 6 comments

Proposed changes:

  • Add italian spacy model docker image

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [x] updated the documentation
  • [x] updated the changelog (please check changelog for instructions)
  • [x] reformat files using black (please check Readme for instructions)

ibaylyak avatar Aug 30 '22 09:08 ibaylyak

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 30 '22 09:08 CLAassistant

@aerowithanl What should I do to fix unsuccessful checks?

ibaylyak avatar Aug 31 '22 10:08 ibaylyak

@ibaylyak this looks good to me, can you please rebase against main.

done

ibaylyak avatar Aug 31 '22 16:08 ibaylyak

@sanchariGr do I have to do anything else?

ibaylyak avatar Sep 08 '22 12:09 ibaylyak

@sanchariGr do I have to do anything else?

@ibaylyak Apologies for the late reply, unfortunately the building docker image failure issue that you are facing here is expected since you donot have the required permissions. We would need a bit longer to come up with a solution for you.

sanchariGr avatar Sep 21 '22 12:09 sanchariGr

@sanchariGr do I have to do anything else?

@ibaylyak Apologies for the late reply, unfortunately the building docker image failure issue that you are facing here is expected since you donot have the required permissions. We would need a bit longer to come up with a solution for you.

Ok

ibaylyak avatar Sep 21 '22 13:09 ibaylyak

@ibaylyak I've just merged what I hope is a fix to main - let's see if this works for you now.

rasa-jmac avatar Sep 22 '22 15:09 rasa-jmac

@ibaylyak I've just merged what I hope is a fix to main - let's see if this works for you now.

ok, thank you.

ibaylyak avatar Sep 22 '22 17:09 ibaylyak

@ibaylyak We don't seem to be having very good luck with the CI checks for this PR. We're still investigating on our side and actively working on this.

rasa-jmac avatar Sep 23 '22 14:09 rasa-jmac

@ibaylyak Hello, thank you for your patience on this, I kindly ask you to rebase against main once more and lets see if we have more luck this time :)

miraai avatar Oct 25 '22 13:10 miraai

@miraai Hello, I had a conflict in .github/workflows/continous-integration.yml

ibaylyak avatar Oct 25 '22 14:10 ibaylyak