rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Socketio metadata

Open rgstephens opened this issue 1 year ago • 8 comments

As suggested by @ancalita this is a replacement PR for #11100 re-based to 3.2.x. Closing #11000.

Proposed changes:

  • Adds metadata to the socket.io channel as requested in #11087

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [x] updated the documentation
  • [x] updated the changelog (please check changelog for instructions)
  • [x] reformat files using black (please check Readme for instructions)

rgstephens avatar Aug 11 '22 17:08 rgstephens

@ancalita I note you said:

I see this is targeting main actually, I'd recommend you rebase to 3.2.x and edit target branch on GH for the change to make it in the next micro release.

I rebased to 3.2.x for this PR but I'm confused about whether the PR should target main or not? By default, when creating a PR github defaults to targeting main so I'm going with that but maybe my target is supposed to be 3.2.x?

rgstephens avatar Aug 11 '22 18:08 rgstephens

@ancalita I note you said:

I see this is targeting main actually, I'd recommend you rebase to 3.2.x and edit target branch on GH for the change to make it in the next micro release.

I rebased to 3.2.x for this PR but I'm confused about whether the PR should target main or not? By default, when creating a PR github defaults to targeting main so I'm going with that but maybe my target is supposed to be 3.2.x?

@rgstephens oh yes, feel free to change the target in Github UI if you branched off 3.2.x to begin with. I always change the target branch to the one I've branched off.

ancalita avatar Aug 11 '22 18:08 ancalita

Changed target branch to 3.2.x

rgstephens avatar Aug 11 '22 18:08 rgstephens

Why are the docs failing with dead link errors for links that are working?

3227:3-3227:54  warning  Link to https://github.com/RasaHQ/rasa/issues/5413 is dead         no-dead-urls  remark-lint
[75](https://github.com/RasaHQ/rasa/runs/7794964820?check_suite_focus=true#step:13:76)
   3238:3-3238:54  warning  Link to https://github.com/RasaHQ/rasa/issues/5402 is dead         no-dead-urls  remark-lint
[76](https://github.com/RasaHQ/rasa/runs/7794964820?check_suite_focus=true#step:13:77)
  3689:7-3689:147  warning  Link to https://github.com/huge-success/sanic/issues/1729 is dead  no-dead-urls  remark-lint
[77](https://github.com/RasaHQ/rasa/runs/7794964820?check_suite_focus=true#step:13:78)
  3704:7-3704:147  warning  Link to https://github.com/huge-success/sanic/issues/1729 is dead  no-dead-urls  remark-lint

rgstephens avatar Aug 11 '22 20:08 rgstephens

Why are the docs failing with dead link errors for links that are working?

Mysterious flaky tests 🤷🏻 I just re-run until I get a 🟢

ancalita avatar Aug 12 '22 14:08 ancalita

Re-ran and fixed the docs dead links but now getting a codeclimate upload failure. Re-running didn't fix it:

/home/runner/work/rasa/rasa/cc-reporter upload-coverage -i coverage.total.json --debug
[898](https://github.com/RasaHQ/rasa/runs/7823812246?check_suite_focus=true#step:6:899)
Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag

rgstephens avatar Aug 14 '22 03:08 rgstephens

now getting a codeclimate upload failure.

You can ignore these, they are not required checks, we can merge them without them being 🟢

ancalita avatar Aug 15 '22 08:08 ancalita

I've just noticed a module got added src/dashbotpy, could you also please remove it?

Sorry about that. Fixed.

rgstephens avatar Sep 12 '22 15:09 rgstephens