rasa
rasa copied to clipboard
RasaHQ
Make rasa validate cli have an option to turn off colors
Proposed changes:
- Make rasa cli have an option to turn off colors in rasa validate
Fixes:
- #9757
Status (please check what you already did):
- [x] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog (please check changelog for instructions)
- [x] reformat files using
black(please check Readme for instructions)
@thiagohdaqw do we need the option both via the env var via the command line? I'd prefer doing it either one way or the other, so there's no ambiguity, and the code will be simpler.
It's really redundant. I think it makes more sense to keep only the env var. Thanks for the review, I will make the changes
@thiagohdaqw code looks good, just approved it for CI. One last thing: could you also add a description of this new feature to the documentation where the corresponding rasa run target is described?
@thiagohdaqw code looks good, just approved it for CI. One last thing: could you also add a description of this new feature to the documentation where the corresponding rasa run target is described?
@losterloh Where exactly should we add the feature documentation in the docs? We can't seem to find where it's the right place to write it
I would recommend inserting it as a :::tip in docs/docs/command-line-interface.mdx.
Hi @thiagohdaqw, in order to merge this PR we need to fix the Documentation Linting Checks, can you please run make lint-docs and fix the issue that its complaining about.
