rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Socketio metadata

Open rgstephens opened this issue 2 years ago • 4 comments

Proposed changes:

  • Adds metadata to the socket.io channel as requested in #11087

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [x] updated the documentation
  • [x] updated the changelog (please check changelog for instructions)
  • [x] reformat files using black (please check Readme for instructions)

rgstephens avatar Apr 24 '22 01:04 rgstephens

@rgstephens Following up on this if you'd want a 2nd review from me?

ancalita avatar Jul 06 '22 10:07 ancalita

yes, thanks for the reminder

rgstephens avatar Jul 06 '22 16:07 rgstephens

Before I give the final approval, asked a clarifying question on a docs sentence. Also please add a unit test if possible, that the metadata gets added to the UserMessage object.

Have not done unit tests before in Python so this make take me a while. Might be best to withdraw this PR rather than waiting on me to do this.

rgstephens avatar Jul 22 '22 16:07 rgstephens

Before I give the final approval, asked a clarifying question on a docs sentence. Also please add a unit test if possible, that the metadata gets added to the UserMessage object.

Have not done unit tests before in Python so this make take me a while. Might be best to withdraw this PR rather than waiting on me to do this.

As you prefer!

ancalita avatar Jul 25 '22 08:07 ancalita

@rgstephens Have you rebased recently? I just tried to review but see over 200 commits in this PR, might be easier to recreate PR targeting 3.2.x and close this one, we are actually planning a micro by the end of this week, latest early next week. I am available to give a fast review too 👍🏻

ancalita avatar Aug 11 '22 12:08 ancalita

Closing. Rebased to 3.2.x and replaced by PR #11435

rgstephens avatar Aug 11 '22 17:08 rgstephens