rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Published 20 hours ago • verified publisher icon RasaHQ

DRAFT: 2.8.x fix visualization

Open raoulvm opened this issue 2 years ago • 5 comments

Proposed changes:

  • ...

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [ ] updated the changelog (please check changelog for instructions)
  • [ ] reformat files using black (please check Readme for instructions)

raoulvm avatar Feb 22 '22 16:02 raoulvm

Can you please add test by asserting the properties of the nodes in the generated graph? This test has an example to generate the graph from a story.

hsm207 avatar Apr 07 '22 15:04 hsm207

@raoulvm the headline says DRAFT, but it's not a draft PR; is this ready for review or still work in progress?

losterloh avatar Jun 01 '22 08:06 losterloh

@raoulvm the headline says DRAFT, but it's not a draft PR; is this ready for review or still work in progress?

Hi Lukas @losterloh , it is a bit of draft, even with @hsm207 work.
But as a corporate (paying) customer of Rasa I expected the rasa devs to jump in here and complete the PR - or at least grab the ideas and implement them in their favorite way.

I created that to show how issue #10941 could be solved.

raoulvm avatar Jun 01 '22 09:06 raoulvm

OIC the issue: Writing "DRAFT:" before the PR name is gitLAB syntax, while GitHUB uses a flag and no magic word.

raoulvm avatar Jun 01 '22 09:06 raoulvm

Hi @raoulvm , thanks for your explanation! We'll see about prioritizing this in accordance with our current roadmap.

losterloh avatar Jun 01 '22 13:06 losterloh