rasa icon indicating copy to clipboard operation
rasa copied to clipboard

Published 20 hours ago • verified publisher icon RasaHQ

remove _warn_and_correct_transformer_size funct

Open emysdias opened this issue 2 years ago • 5 comments

Proposed changes:

  • Removes unusual function as you can see the issue here: https://github.com/RasaHQ/rasa/issues/10712

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [ ] updated the changelog (please check changelog for instructions)
  • [x] reformat files using black (please check Readme for instructions)

emysdias avatar Feb 06 '22 21:02 emysdias

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 06 '22 21:02 CLAassistant

@jupyterjazz can you check later please? And I don't know why codeclimate failed if I didn't change these files :(

emysdias avatar Feb 09 '22 03:02 emysdias

Just to let you know that I'm going to go back with this PR and @WashingtonBispo is going to help too

emysdias avatar Feb 19 '22 19:02 emysdias

hey @emysdias , is this still relevant / are you still planning on working on this? 🙂

losterloh avatar Jun 01 '22 09:06 losterloh

hey @emysdias , is this still relevant / are you still planning on working on this? slightly_smiling_face

I dont know, I got no answer anymore and not going to work on this anymore

emysdias avatar Jun 01 '22 23:06 emysdias

Hi there! Thanks for your contribution. As the PR has been stale for a while, I'm closing it. Please feel free to reopen an issue / PR if the problem still occurs on latest rasa versions.

m-vdb avatar May 25 '23 07:05 m-vdb