leaflet-rotate icon indicating copy to clipboard operation
leaflet-rotate copied to clipboard

Fix floating layers while moving map

Open rphlo opened this issue 1 year ago • 3 comments

FIx #43

rphlo avatar Nov 04 '24 06:11 rphlo

Hi @rphlo, I don't have much time to follow this properly right now.

Since you have already sent other PRs in the past, would you like to be added as a repo collaborator?

Raruto avatar Nov 25 '24 21:11 Raruto

It would be a shame to have this repo abandoned, however I also do not have the time to overlook another project, and I do not feel like I have a full understanding of this one either, my contributions so far have been minor. This PR is tiny, and I hope you will find time to review it at some point so that others can enjoy the improvement it made for me... but I understand if we have to wait a bit.

rphlo avatar Nov 26 '24 08:11 rphlo

Call me weird, but I don't own a touchable device, surely there will be other ways to test such things, but more brains wouldn't hurt..

my contributions so far have been minor.

Yes, for this reason too. I like concise solutions (less reads/tests).

I do not feel like I have a full understanding of this one either

Me niether.. 😄 (though overall I think it's quite stable)

BTW, basic functioning is explained in here: https://github.com/Raruto/leaflet-rotate/issues/17#issuecomment-1380014268


My expectations for this plugin are pretty basic..

That's why I would recommend anyone who has a project based on this to join the repository.

Raruto avatar Nov 26 '24 09:11 Raruto