lumberjack-core icon indicating copy to clipboard operation
lumberjack-core copied to clipboard

Add custom taxonomy support

Open idflood opened this issue 4 years ago • 13 comments

What does this implement/fix?

As discussed here this adds support for custom taxonomy. I took the same structure and way of doing things as the custom "Post" types so it should be consistent with this.

Does this close any currently open issues?

Yes, it should fixes https://github.com/Rareloop/lumberjack/issues/16

Any relevant logs, error output, etc?

No :) and all added test are ✔

Any other comments?

We will add Lumberjack to our base theme and taxonomies is a must. Let me know if I need to make some changes, I would be more than happy to help with this feature : )

And once it's merged I will make the required changes to document it here with a pull request https://github.com/Rareloop/lumberjack-docs

idflood avatar Oct 02 '20 07:10 idflood

Coverage Status

Coverage increased (+0.004%) to 88.785% when pulling 4134412fd3d546767091fd8545f0c5a4b9f659c0 on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Coverage Status

Coverage increased (+0.004%) to 88.785% when pulling 4134412fd3d546767091fd8545f0c5a4b9f659c0 on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Coverage Status

Coverage increased (+0.004%) to 88.785% when pulling 4134412fd3d546767091fd8545f0c5a4b9f659c0 on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Coverage Status

Coverage increased (+0.004%) to 88.785% when pulling 4134412fd3d546767091fd8545f0c5a4b9f659c0 on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Coverage Status

Coverage increased (+0.004%) to 88.785% when pulling 4134412fd3d546767091fd8545f0c5a4b9f659c0 on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Coverage Status

Coverage increased (+0.004%) to 88.785% when pulling 4134412fd3d546767091fd8545f0c5a4b9f659c0 on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Coverage Status

Coverage increased (+0.02%) to 88.797% when pulling 92c93823d30a530001c9369164577d9ef94fc0ae on idflood:features/add-custom-taxonomy-support into 46105b87926d18d7036169290a091611c4fbddca on Rareloop:master.

coveralls avatar Oct 02 '20 07:10 coveralls

Hi, when it will be merged to the core ? thank you

claudelebo avatar Apr 12 '21 11:04 claudelebo

I'm also interested to know if it will be merged at some point.

daltonrooney avatar Jun 29 '21 16:06 daltonrooney

I am also interested to know when it will be merged.

Androlax2 avatar Jul 20 '21 15:07 Androlax2

Is there a timeline for when this will be merged? I would like to use Lumberjack professionally but this is quite a large missing feature which makes me reluctant to implement it in my workplace just yet.

AlexSBlackburn avatar Oct 25 '21 07:10 AlexSBlackburn

+1 on this merge request, any idea when this could be implemented?

nealoke avatar Oct 29 '21 12:10 nealoke

🆙

arnaudbagnis avatar Nov 09 '22 17:11 arnaudbagnis