Rare icon indicating copy to clipboard operation
Rare copied to clipboard

[BUG] Closing Rare doesn't exit threads

Open rjbprime opened this issue 2 years ago • 2 comments

Describe the bug When closing Rare after a download, threads are still running, and must be terminated with task manager.

To Reproduce Steps to reproduce the behavior:

  1. Download a game.
  2. Either let it complete or cancel it.
  3. Right click on tray icon and click exit.
  4. See error

Expected behavior Threads exit immediately.

Screenshots Not really applicable,

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: 1.8.9
  • Installation: MSI
  • Python 3.10

Additional context Not a major issue, but if needing to delete a folder/file after canceled download, whilst one of the threads are actively using it, windows fails to delete the file, saying it is in use.

Error message

rjbprime avatar Jul 16 '22 09:07 rjbprime

Thanks for reporting. I will try to reproduce the error. Did you have games in queue, which started? And the download was completed? Spontaneous I have no idea, why this happens.

Dummerle avatar Jul 16 '22 17:07 Dummerle

I did, but then I cancelled them before they started. The one that had started was cancelled after the others were cancelled, so I would think it would close all open threads.

rjbprime avatar Jul 17 '22 02:07 rjbprime