react-native-tcp-socket icon indicating copy to clipboard operation
react-native-tcp-socket copied to clipboard

fix a bug of socket.write function

Open itgou opened this issue 3 years ago • 1 comments

hello, when call write func with default encode utf8 and callback , I think it is more convenience to only pass to params: (buffer,cb); Nodejs also did it this way.

itgou avatar Oct 09 '21 06:10 itgou

@itgou, thanks for the PR! However, while this is correct as implementation, it must also be reflected in the type declaration file for the Typescript users. If you do not have knowledge about JSDoc, I can take your implementation and add the corresponding JSDoc.

Rapsssito avatar Oct 09 '21 10:10 Rapsssito