discord.py icon indicating copy to clipboard operation
discord.py copied to clipboard

Published 20 hours ago • verified publisher icon Rapptz

Add type attribute to Invite

Open codeofandrin opened this issue 1 year ago • 2 comments

Summary

This PR adds the type attribute to Invite. As mentioned in the related PR this change got rejected multiple times. But I don't see why. Is there a specific reason it shouldn't be implemented in the library, that I don't know?

Related PR: https://github.com/discord/discord-api-docs/pull/6568

Checklist

  • [x] If code changes were made then they have been tested.
    • [x] I have updated the documentation to reflect the changes.
  • [ ] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

codeofandrin avatar Dec 12 '23 21:12 codeofandrin

The reason why I believe this wasn't documented is because the various types of invites were all experiments that didn't pan out. Friend invites died, and I don't think group invites are a thing anymore.

Rapptz avatar Jan 27 '24 01:01 Rapptz

Alright. Let's wait though what the ddevs say to it, unless you already know more than I do about whether something like this will be documented in the future.

codeofandrin avatar Jan 27 '24 13:01 codeofandrin

The related PR on Discord's side has been merged.

codeofandrin avatar May 17 '24 10:05 codeofandrin