Add ability to use primary guild (clan) data for users

[blord0]

Summary

Checklist

• [x] If code changes were made then they have been tested.
  • [x] I have updated the documentation to reflect the changes.
• [ ] This PR fixes an issue.
• [x] This PR adds something new (e.g. new method or parameters).
• [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
• [ ] This PR is not a code change (e.g. documentation, README, ...)

[Soheab]

There is already a PR for this: #10190 ~~even though this implementation looks majorly better~~

[blord0]

Looks nice, but still needs to wait for discord to document this

Any idea how often discord updates their documentation? Latest pull in discord's api docs for tags was opened 2nd May 2024 and has not been updated in the past 3 weeks https://github.com/discord/discord-api-docs/pull/6836

[blord0]

Also the api does seem to be stable. From https://github.com/discord/discord-api-docs/pull/6836#issuecomment-2119306871 (19th May 2024) you can see that they still use the same fields of tag, identity_guild_id, identity_enabled and badge. Only part that has changed is it is now under the primary_guild section, not clan

[DA-344]

You'll need to wait for Discord to just merge the documentation of it, and although it looks stable doesn't mean it will always be, rn is not documented so they have an excuse to (although even documented they do) break the field at any point.

[blord0]

You'll need to wait for Discord to just merge the documentation of it, and although it looks stable doesn't mean it will always be, rn is not documented so they have an excuse to (although even documented they do) break the field at any point.

Yea I get that, but tags have been rolled out to all servers now. The one change discord did was the field name from clan -> primary_guild due to clans being deprecated (I would argue that this is an even stronger indication that they won't change as the fields of tag, identity_guild_id, identity_enabled and badge are all the same even after a renaming, as that would have been the perfect point to re-do anything they wanted to do)

+In the unlikely event they do, I would be more than happy to fix/patch/whatever the code

[DA-344]

Still, docs must be merged first

[Rapptz]

Generally speaking I don't merge features that are undocumented because we've been bitten by it in the past (most recently, voice channel statuses) and it's not worth the upkeep.

[Soheab]

The API docs have been merged per https://github.com/discord/discord-api-docs/commit/a1bac5f61574df372c44d73624e725c2c9ef8bc1 !

[blord0]

Just double checked the docs and everything seems good to me https://discord.com/developers/docs/resources/user#user-object-user-primary-guild

[blord0]

Sorry for delays, was on holiday