ImmediatelyFast icon indicating copy to clipboard operation
ImmediatelyFast copied to clipboard

Depth Func GL State getting corrupted in some cases

Open AzureAaron opened this issue 1 year ago • 3 comments

When using Skyblocker's Fairy Souls Helper feature with IF, the translucent block part of waypoints are supposed to be rendered through walls but are not. It seems as though IF is causing the Depth Function GL State during to corrupt during rendering in certain cases.

We render the waypoints in one batch after all AFTER_TRANSLUCENT events have been fired (the waypoints are written to the render layers during the default phase of the event) through a custom render layer.

Steps to reproduce:

  1. Install the latest version of Skyblocker (currently 1.17 for 1.20.4)
  2. Join Hypixel, enter Skyblock then go to the hub
  3. Type /skyblocker config and under the Fairy Soul Helper section enable the helper
  4. Go to 42, 70, -66 (To the right of where you spawn in the hub inside the building that's purple and looks like a potion bottle)
  5. Observe how the translucent block part of the waypoint isn't being rendered through the floor

Interestingly enough, I haven't been able to reproduce this issue when using Skyblocker's dungeon secret waypoints which are rendered the exact same way.

IF Version: 1.2.8+1.20.4 Mods used: Fabric API, Skyblocker, Immediately Fast

With IF: 2024-01-26_21 18 41 Without IF: 2024-01-26_21 19 33

AzureAaron avatar Jan 27 '24 03:01 AzureAaron

Interesting issue. I quickly looked through the Skyblocker code parts you linked and everything looked good. I currently don't have much time to work on my projects, so I can't tell you how long it takes until I can get time to fix it

RaphiMC avatar Jan 27 '24 07:01 RaphiMC

Still occurs with IF 1.2.10+1.20.4

AzureAaron avatar Feb 03 '24 05:02 AzureAaron

Still happens with IF 1.2.11+1.20.4, weirdly this doesn't happen when Iris (version 1.6.17) is installed so perhaps this is a bug with the compatibility layer.

AzureAaron avatar Mar 28 '24 06:03 AzureAaron