ImmediatelyFast icon indicating copy to clipboard operation
ImmediatelyFast copied to clipboard

Transparency Issues with Hud rendering (Iron's Spells & Spellbooks)

Open iron431 opened this issue 1 year ago • 5 comments

Versions:

Forge: 1.20.1-47.1.3 ImmediatelyFast 1.2.7+1.20.2 Iron's Spells 'n Spellbooks 1.20.1-2.1.1

Mods:

  • Iron's Spell's 'n Spellbooks
  • ImmediatelyFast
  • Curios (dep of iron's spellbooks)
  • Geckolib (dep of iron's spellbooks)
  • caelus (dep of iron's spellbooks)
  • playeranimator (dep of iron's spellbooks)

Several of the Iron's Spells & Spellbooks (https://legacy.curseforge.com/minecraft/mc-mods/irons-spells-n-spellbooks) transparent hud elements become fully opaque when using immediately fast

Spell Bar Overlay

Steps to reproduce:

  1. Hold a spellbook (such as the Blood Staff, which has pre-slotted spells)

What it's supposed to look like: image

With ImmediatelyFast: image (both items have the same spells equipped)

Spell Bar and Item Decorator Cooldown Overlay

Steps to reproduce:

  1. Obtain a spellbook with spells
  2. Cast a spell

What it's supposed to look like: image

With ImmediatelyFast (Notice Spell bar is opaque; Item is on top of hotbar overlay): image

Additional Examples: https://github.com/iron431/Irons-Spells-n-Spellbooks/issues/231

iron431 avatar Dec 03 '23 06:12 iron431

I should add, after looking at the hud code, it hasn't been optimized since the direct port from 1.19. i'd appreciate more information on the issue as i'm no rendering expert and i don't know what immediately fast does behind the scenes.

iron431 avatar Dec 03 '23 07:12 iron431

Also, when ImmediatelyFast is installed when using Iron's Spells this also happens:

Heartstop spell without Immediately Fast:

image

Heartstop spell with Immediately Fast:

image

Here is the list of mods in the test without ImmediatelyFast

mod_id,mod_name,mod_version,mod_file,mod_url,display_url,issue_tracker_url
minecraft,Minecraft,1.20.1,client-1.20.1-20230612.114412-srg.jar,,,
caelus,Caelus API,3.1.0+1.20,caelus-forge-3.1.0+1.20.jar,,https://github.com/TheIllusiveC4/Caelus,https://github.com/TheIllusiveC4/Caelus/issues
forge,Forge,47.2.0,forge-1.20.1-47.2.0-universal.jar,,,http://www.minecraftforge.net/
curios,Curios API,5.4.7+1.20.1,curios-forge-5.4.7+1.20.1.jar,,https://www.curseforge.com/minecraft/mc-mods/curios,https://github.com/TheIllusiveC4/Curios/issues
patchouli,Patchouli,1.20.1-84-FORGE,Patchouli-1.20.1-84-FORGE.jar,,,https://github.com/VazkiiMods/Patchouli
geckolib,GeckoLib 4,4.4,geckolib-forge-1.20.1-4.4.jar,,http://geckolib.com/,https://github.com/bernie-g/geckolib/issues
playeranimator,Player Animator,1.0.2-rc1+1.20,player-animation-lib-forge-1.0.2-rc1+1.20.jar,,,
irons_spellbooks,Iron's Spells 'n Spellbooks,1.20.1-2.2.1,irons_spellbooks-1.20.1-2.2.1.jar,,https://www.curseforge.com/minecraft/mc-mods/irons-spells-n-spellbooks,https://github.com/iron431/Irons-Spells-n-Spellbooks/issues

The only change is adding this

immediatelyfast,ImmediatelyFast,1.2.8+1.20.4,ImmediatelyFast-Forge-1.2.8+1.20.4.jar,,,https://github.com/RaphiMC/ImmediatelyFast/issues

lab3 avatar Jan 17 '24 15:01 lab3

We have a couple people a day show up in our discord with this and our only option at the moment is to tell them to remove ImmediatelyFast. If there is something on our end we can do let's discuss

You can hit up Smalls or Iron in the discord https://discord.gg/4gDYuJtK

lab3 avatar Jan 17 '24 15:01 lab3

Try disabling hud_batching in the config file and check if that fixes it for now

RaphiMC avatar Jan 17 '24 15:01 RaphiMC

Looks like that resolves the heartstop issue.

lab3 avatar Jan 17 '24 16:01 lab3

Can confirm immediatelyfast version above 1.2.13 also fixed this 2024-05-07_01 54 51

liangmoe avatar May 06 '24 17:05 liangmoe