survivalmodels icon indicating copy to clipboard operation
survivalmodels copied to clipboard

Feature custom validation set

Open diego-s opened this issue 3 years ago • 2 comments

This pull request addresses Issue #25 adding support for custom validation sets by passing an array of integer validation set indices as the 'frac' argument instead of a scalar fraction value.

diego-s avatar Feb 21 '22 08:02 diego-s

Thanks @diego-s I really appreciate the contribution. But a couple small points:

  1. It doesn't make sense to me to have a parameter called frac that is passing indices. It would make more sense to have two separate parameters like frac and validation_indices (or any other name) where only one can be non-NULL
  2. Please update the documentation to reflect the new parameters
  3. I'd appreciate if you can extend this to dnnsurv
  4. Please add tests to cover the new method

RaphaelS1 avatar Feb 27 '22 11:02 RaphaelS1

Codecov Report

Merging #28 (eaccf43) into main (7bca543) will decrease coverage by 0.12%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main      #28      +/-   ##
===========================================
- Coverage   100.00%   99.87%   -0.13%     
===========================================
  Files           16       16              
  Lines          768      770       +2     
===========================================
+ Hits           768      769       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
R/helpers_pycox.R 99.63% <66.66%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bca543...eaccf43. Read the comment docs.

codecov-commenter avatar Feb 27 '22 11:02 codecov-commenter