survivalmodels
survivalmodels copied to clipboard
Feature custom validation set
This pull request addresses Issue #25 adding support for custom validation sets by passing an array of integer validation set indices as the 'frac' argument instead of a scalar fraction value.
Thanks @diego-s I really appreciate the contribution. But a couple small points:
- It doesn't make sense to me to have a parameter called
fracthat is passing indices. It would make more sense to have two separate parameters likefracandvalidation_indices(or any other name) where only one can be non-NULL - Please update the documentation to reflect the new parameters
- I'd appreciate if you can extend this to dnnsurv
- Please add tests to cover the new method
Codecov Report
Merging #28 (eaccf43) into main (7bca543) will decrease coverage by
0.12%. The diff coverage is66.66%.
@@ Coverage Diff @@
## main #28 +/- ##
===========================================
- Coverage 100.00% 99.87% -0.13%
===========================================
Files 16 16
Lines 768 770 +2
===========================================
+ Hits 768 769 +1
- Misses 0 1 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| R/helpers_pycox.R | 99.63% <66.66%> (-0.37%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7bca543...eaccf43. Read the comment docs.