polishedcrystal
polishedcrystal copied to clipboard
Rangi42
Double forfeit in link causes issues, and exchanged pokemons are corrupted
Exchanging pokemons always result on adding a corrupted pkmn to both players parties.
The code responsible of that seems to be around the .done_animation label, from engine/link.asm
Restoring the original Pokecrystal code fix that behavior. I have reasons to believe that the new CopyBetweenPartyAndTemp is causing that.
Tested with BGB link emulation.
(Leaving a fight in VS mode results in a weird behavior too, maybe it's linked ?)
It seems that it's fixed on 9bit: https://github.com/Rangi42/polishedcrystal/commit/a78a59b29b15f66c03418b5160ba044cf68a5df4
EDIT: cherry-picking that commit on master fixes the problem. There is also an issue with fleeing from battle, I'll check if it's fixed on 9bit too, and see if its possible de cherry-pick that fix too.
There is also an issue with fleeing from battle
Can you elaborate? This is the first time I hear of it.
I believe they are referring to Fleeing from the link battles.. I remember encountering that problem; but I don't remember if that was master or 9-bit. IIRC, if one of the player's chose to leave the battle.. they would leave normally.. but the other player would be stuck in battle.
@Cl0v1s Can you confirm? Or did you have a different issue.
Sorry if I was unclear.
Indeed I'm speaking about fleeing from Link Battle.
Sometimes (it happens really often but I achieved to flee safely a few times, I believe it's related to master/slave link status), when player 1 flees the fight, he can leave it without problem.
However player 2 will stay in fight and (at least in my case) a Nidoran will be sent by the "ghost" player 1.
Then the game while wait forever, since player 1 wont send any battle command because for them, the fight is over.
Indeed those problemes appear to have been resolved in 9-bit, but still not on master / releases available to the public.