RandyGaul
Another popping fix for your perusal
Hi Randy, I was still getting a lot of popping on pitch shifted noises in my game, and I think I've found the real source of the issue (overflowing the channel buffers). Cheers -Brie
Interesting! Thanks a lot. Do you have an audio clip, and a tiny C program to run that repros the issue? So I can see before/after. It's ok if not, it would just save me some time.
Did you see this issue here and try this patch out by any chance? https://github.com/RandyGaul/cute_headers/issues/403
Hi hello! Well, I have a recording: https://www.youtube.com/watch?v=JH_AtYgAGZo It's the pitch shifted 'clang' noises that were causing the popping... weirdly only audible in debug mode for the most part. I can send you the sfx on discord if you like! (It seems to be the case that this out of bounds sampling is/was only an issue for files with a multiple of four amount of samples, which would make sense to me) As for #403... I think I've been getting that glitch too, and didn't know what was causing it. I've just done that patch (more or less) and will report back!
Okay, I've uploaded a more comprehensive patch addressing the resampler and looped sounds, which should also incoroporate the samples_needed patch as that variable is no longer modified in this version. I haven't tested it thoroughly yet so don't trust me too quickly.
All good, I don't mind. Thanks a lot for taking some time to catch these sorts of bugs. Let me know when you want me to take a closer look and review things, whenever it's ready.