vscode-data-preview icon indicating copy to clipboard operation
vscode-data-preview copied to clipboard

Published 20 hours ago • verified publisher icon RandomFractals

Add monospace theme variations

Open mhkeller opened this issue 4 years ago • 4 comments

Per https://github.com/RandomFractals/vscode-data-preview/issues/196

Needs testing

mhkeller avatar Apr 06 '20 17:04 mhkeller

Ah sorry about that – yes the whitespace is annoying. It's the default on my editor. May be good to throw an .editorconfig file in there. If I get some time to come back to it I can redo it to make a merge nicer. But at least you can test the functionality for now.

mhkeller avatar Apr 07 '20 04:04 mhkeller

don't worry about it. I did not notice before those extra spaces were there.

Thanks for that cleanup. I'll merge it later this week.

RandomFractals avatar Apr 07 '20 04:04 RandomFractals

Since the CSS comes from the perspective library, I suggested they also use monospace and there's some interesting feedback from one of the collaborators on how they're changing the codebase: https://github.com/finos/perspective/issues/1008

mhkeller avatar Apr 07 '20 16:04 mhkeller

yeah, I've seen their updates for new data grid setup. thanks for logging this feature request it in their repo.

RandomFractals avatar Apr 07 '20 19:04 RandomFractals

Closing this PR per comments in #196 and more info you provided in perspective repo above.

RandomFractals avatar Aug 25 '22 12:08 RandomFractals