David Rickard

persistentIds grows without bound?

2

Looking at this code: https://github.com/MatthieuLemoine/electron-push-receiver/blob/master/src/index.js It looks like persistentIds just grows with each push notification received. And each time you get a message, it's parsing out the whole list from...

An API this library relies on will be turned off June 20, 2024

27

This library calls https://fcm.googleapis.com/fcm/connect/subscribe for the final FCM subscription step, which I confirmed with the Firebase team to be slated for removal on June 20, 2024. This is not in...

Typescript types not exported properly

1

Types are not exported with the package. For example, [windows.ui.notifications has no TS/DT listing on npm](https://www.npmjs.com/package/@nodert-win10-rs4/windows.ui.notifications). Looking inside node_modules, I see `NodeRT_Windows_UI_Notifications.d.ts` with types fully specified there. However: 1) They...

common.gypi not found

2

Trying to install and getting this error: `C:\Users\david\AppData\Local\node-gyp\Cache\16.17.1\common.gypi not found (cwd: C:\git\electron-quick-start-typescript\node_modules\@nodert-win10-rs4\windows.ui.notifications) while reading includes of binding.gyp while trying to load binding.gyp` Verbose log from node-gyp: ``` gyp info it...

I've done the following things * Manually copied InteractiveNotifications.dll to resolve a runtime error * Fixed up calls to v8::String::Value compile error in notification_bindings.cc * Manually updated CLSID in two...

Compilation error with v8::String::Value::Value

2

I installed the Windows 10 SDK 10.0.10586 and the MSVC v140 - VS 2015 C++ Build Tools from the Visual Studio installer. However, installing the package still gives this compilation...

Fix memoization for Animated components when no style is passed in

1

Summary: Any component wrapped via `createAnimatedComponent()` will always re-render, because it creates a new `style` object. It's impossible to memoize. Adding `useMemo()` here ensures that the `style` object passed to...

Documentation for `name` property on Squirrel maker config is incorrect

3

### Pre-flight checklist - [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project. - [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses. - [X]...

Some containers let you resolve a type even if you haven't registered it, by examining the constructor and resolving all the dependencies, but a lot of them don't. Can you...

New Crowdin translations by [Crowdin GH Action](https://github.com/crowdin/github-action)