IdSharpCore icon indicating copy to clipboard operation
IdSharpCore copied to clipboard

Removes System.Drawing from IdSharp.Tagging

Open atruskie opened this issue 5 years ago • 0 comments

Hi!

Please excuse the direct PR but I figured it was easier to submit a patch with the work done (and to change it if necessary) rather than explain this in an issue.


When installing this library via nuget, it also attempt to install System.Drawing (and System.Win32.Events):

image

Coupling this library with System.Drawing for one use case is unnecessary, especially when many libraries have gone to great pains to remove System.Drawing form their stacks.

This commit moves the System.Drawing parts of AttachedPicture into a separate project so that those references do not pollute the main library.

More work is needed to, especially in deciding whether or not to keep the AttachedPictureWithImage class and possibly publishing a new nuget package as well.

What do you think?

atruskie avatar Jan 30 '19 06:01 atruskie