NetNewsWire icon indicating copy to clipboard operation
NetNewsWire copied to clipboard

Published 20 hours ago • verified publisher icon Ranchero-Software

Logging changes

Open stuartbreckenridge opened this issue 1 year ago • 4 comments

For review; related to #3637

  • Adds Logging protocol
  • Moves to Swift-style OSLog usage

stuartbreckenridge avatar Aug 03 '22 12:08 stuartbreckenridge

That Logging protocol looks generally, very useful. Maybe we should put it in RSCore?

vincode-io avatar Aug 03 '22 15:08 vincode-io

I thought about it but didn't have enough time to check if any of the extension targets required Logging but not RSCore.

stuartbreckenridge avatar Aug 03 '22 15:08 stuartbreckenridge

Let's go ahead and put Logging in RSCore and add RSCore to any extensions that need Logging, but don't have RSCore.

vincode-io avatar Aug 03 '22 15:08 vincode-io

Since this fix is scheduled to go into 6.1.1 we will need to merge it into mac-release and then into ios-release after iOS 6.1 is released.

vincode-io avatar Aug 03 '22 15:08 vincode-io

Removing os_log and replacing with Logger via the Logging protocol is complete for everything bar a few classes that conform to CloudKitZone, which can be tidied up later.

stuartbreckenridge avatar Sep 04 '22 13:09 stuartbreckenridge

@stuartbreckenridge Is there any reason that you didn't change the classes conforming to CloudKitZone? Did you just run out of steam or was there some technical reason?

vincode-io avatar Sep 17 '22 19:09 vincode-io

It needs a commit to RSCore before the final work can be done in the app.

stuartbreckenridge avatar Sep 17 '22 22:09 stuartbreckenridge

Ok. If that isn't something you can get to, I can take a look.

vincode-io avatar Sep 17 '22 22:09 vincode-io

@vincode-io There are no more os_log entries.

stuartbreckenridge avatar Sep 19 '22 01:09 stuartbreckenridge

@stuartbreckenridge Thanks! I just saw that and was about to merge it.

vincode-io avatar Sep 19 '22 01:09 vincode-io