NetNewsWire icon indicating copy to clipboard operation
NetNewsWire copied to clipboard

jsonfeed 1.1 "authors" not supported?

Open jrus opened this issue 4 years ago • 1 comments

I tried copying the content of a jsonfeed example into a feed:

{
    "version": "https://jsonfeed.org/version/1.1",
    "user_comment": "This is a microblog feed. You can add this to your feed reader using the following URL: https://example.org/feed.json",
    "title": "Brent Simmons’s Microblog",
    "home_page_url": "https://example.org/",
    "feed_url": "https://example.org/feed.json",
    "authors": [
        {
            "name": "Brent Simmons",
            "url": "http://example.org/",
            "avatar": "https://example.org/avatar.png"
        }
    ],
    "items": [
        {
            "id": "2347259",
            "url": "https://example.org/2347259",
            "content_text": "Cats are neat. \n\nhttps://example.org/cats",
            "date_published": "2016-02-09T14:22:00-07:00"
        }
    ]
}

NetNewsWire 5.1.3 doesn't pick on any author here. If I change "authors" to "author" and just put one object instead of a list inside, it is handled as expected:

{
    "version": "https://jsonfeed.org/version/1.1",
    "user_comment": "This is a microblog feed. You can add this to your feed reader using the following URL: https://example.org/feed.json",
    "title": "Brent Simmons’s Microblog",
    "home_page_url": "https://example.org/",
    "feed_url": "https://example.org/feed.json",
    "author": {
        "name": "Brent Simmons",
        "url": "http://example.org/",
        "avatar": "https://example.org/avatar.png"
    },
    "items": [
        {
            "id": "2347259",
            "url": "https://example.org/2347259",
            "content_text": "Cats are neat. \n\nhttps://example.org/cats",
            "date_published": "2016-02-09T14:22:00-07:00"
        }
    ]
}

The jsonfeed 1.1 spec says about this:

JSON Feed version 1 specified a singular author field instead of the authors array used in version 1.1. New feeds should use authors, even if only 1 author is needed. Existing feeds can include both author and authors for compatibility with existing feed readers. Feed readers should always prefer authors if present.

jrus avatar Jan 24 '21 01:01 jrus

I found this today as well, I assume it is the same issue so I did not open a new.

If I view a feed which NNW pulls directly ("On My Mac" or iCloud), the author field populates. If I pull the same feed through an aggregator, the author field is blank.

I tested this on both Inoreader and my own FreshRSS instance, and across all of [Big Sur, Monterrey, iOS 14, iOS 15] with [6.0.2, 6.0.3b1, git], the behaviors were the same. I am happy to provide more testing as requested, the author field is important for feeds which are an aggregation of many authors.

Raineer avatar Jul 19 '21 17:07 Raineer