Ramon Van Gorkom

Results 29 comments of Ramon Van Gorkom

> Recommend revising commit message. Compare with previous commits in this repo. Details from [#60 (comment)](https://github.com/openwrt/netifd/pull/60#issuecomment-3533693220) would do well in the commit message. The commit message is not that different...

@systemcrash how about i close this PR, and you recreate it? I guess you carry some more weight around here.

oh well, i will just patch my own installs, guess people do not care enough about security and performance

@stokito Im fine with that

The layout needs some work, especially if the table is empty. See e.g.: ![image](https://github.com/user-attachments/assets/ff5f1c70-ca23-41ec-9b5a-064fa6497077) Looks like you need to fill in an hour value in the empty box instead of...

![image](https://github.com/user-attachments/assets/0845d204-1806-4179-8561-7011b9fb0537)

yes side-by-side would be perfect, i.e. show and allow editing of the resulting cron rules. Maybe also good to add a comment field?

> Fixed I just tested it and indeed now it is functional. Cosmetic remark, maybe add some pixels space here between the two boxes? ![image](https://github.com/user-attachments/assets/7118f4cc-44c3-4d87-8fc5-a0256d0095b1) One more remark, if I...