Benjamin Saunders

Results 1021 comments of Benjamin Saunders

Rebased to resolve conflicts with recent quinn-udp improvements.

> Wow, I tried this pr, and this pr perfectly solves our problems! Awesome, thanks for the report! That's exactly the kind of data I've been hoping for, since this...

> Just a clarification, in the 9000 connections bench, the CPU limit is 4800% but only utilized about 1400%, so I think it's nothing to do with CPU usage. Could...

Thanks for the report! Consider opening a separate issue for regressions in 0.11 base, which are out of scope of this PR. A few questions: - Can you reproduce this...

Closing as stale. Feel free to reopen with additional details if you're still having trouble.

What happens when a `poll_send` call isn't able to transmit all packets immediately, i.e. returns less than `transmits.len()`? It seems difficult to avoid unpredictably double-translating addresses with this change, which...

I'd like to at least see a clearly documented contract for whether or not unsent entries may be changed after the call returns. I think it should specifically guarantee that...

https://github.com/quinn-rs/quinn/pull/1729 will likely render this unnecessary by only accepting a single, trivially rewritten `Transmit` at a time.