IronOS icon indicating copy to clipboard operation
IronOS copied to clipboard

Update build.sh

Open Milacus opened this issue 3 months ago • 4 comments

  • Please check if the PR fulfills these requirements
  • [x] The changes have been tested locally
  • [x] There are no breaking changes
  • What kind of change does this PR introduce? Build process stability improvement

  • What is the current behavior? The TRANSLATION_DIR variable in the source/build.sh file will be a relative path to the location from where the script was called (which could be the root of the repository or anywhere in the system) which will cause the script to fail. To resolve the path correctly one must call the script from within the source/ directory

  • What is the new behavior (if this is a feature change)? Translation dir is now relative to the script directory (and not the location from where the script was called). This way one call call the build.sh script from the root of the repository and it still works.

Milacus avatar Sep 07 '25 10:09 Milacus

The build is successful when run with few enough cores or when every target is built sequentially. I think the build errors shows an issue within the Makefiles. I'll try to dig into it next week.

Milacus avatar Sep 12 '25 22:09 Milacus

Fixed the dependency declarations in the Makefile. The change is a bit bigger than I thought. Still think it would be nice but up to you how/ if you want to proceed with the changes.


EDIT: This does not fully cover the issue yet. I'll have to dig into it when I have some time.

Milacus avatar Sep 12 '25 22:09 Milacus

@Milacus I'm happy for this change. I've never run into this but its perfectly reasonable to me. LMK when your happy.

Ralim avatar Sep 13 '25 10:09 Ralim

Sadly I did not get around to look into the issue and will be going on vacation tonight. I'll pick this up once I'm back. Sorry about the delay.

Milacus avatar Sep 17 '25 19:09 Milacus