Ralim
ts101 gets stuck in boost mode when lock is on
Describe the bug with the lock mode set to B, when soldering with lock on, the boost mode stays on even after i release the button.
To Reproduce Steps to reproduce the behavior:
- set lock mode to B
- exit the settings
- press the first button to turn heating on
- hold both buttons to lock the buttons
- hold first button to activate boost
- release first button
- boost mode stays on
Expected behavior boost mode switches off when i release the button (works on my squire soldering iron)
Details of your device: TS101 V2.23E.DD4A5500 xiaomi 100w laptop charger (problem is not charger related, i use random chargers. this is just one of them i use)
Additional context
I'm seeing the same on my Pinecil V2. Issue is not present in 2.22. Issue is present in 2.23rc1, 2.23rc3, and 2.23rc4. All builds tested were from https://github.com/Ralim/IronOS/releases
It looks like this was lost in the refactor:
~https://github.com/Ralim/IronOS/compare/v2.22...v2.23-rc4#diff-8c50a175baa140c41981bf7da2a97e85d5ac6b25a88b9ee3c2b89fe055ae7e16L40~
https://github.com/Ralim/IronOS/blob/v2.22/source/Core/Threads/OperatingModes/Soldering.cpp#L40
~https://github.com/Ralim/IronOS/compare/v2.22...v2.23-rc4#diff-9e19aca0dc4c0156c58464c504e2c526c6ea2e85155efd23c5876fd2f456c36fR35~
https://github.com/Ralim/IronOS/blob/v2.23-rc4/source/Core/Threads/UI/logic/Soldering.cpp#L35
Adding that logic back in fixed it for me:
This is the only code I've ever looked at in this repo (got my Pinecil last week and noticed this behavior while trying out settings), so I don't feel I'm familiar enough to make a PR at the moment. Hopefully this will help someone with an implementation 😃.
Edit: Diff links don't seem to be working well, so I added links to each version in the source.
