IronOS icon indicating copy to clipboard operation
IronOS copied to clipboard

Expand USB-PD mode option

Open Ralim opened this issue 1 year ago • 0 comments

  • Please check if the PR fulfills these requirements
  • [x] The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?

Fixes #1904 by providing user control for how we select input.

  • What is the new behavior (if this is a feature change)?

This expands the PD menu setting from enable/disable VDPO to instead have 3 options:

  1. Padding 0.5 ohm + PPS/EPR enabled
  2. No Padding 0.5 ohm + PPS/EPR enabled
  3. No Padding 0.5 + PPS/EPR disabled (just fixed PDO's)
  • Other information:

This is currently a solution to the problem. I can't make SRAM over hard-reset be reliable enough in all cases to do this magically easily. I also have supplies that do not fill out the overload bits 😓 .

Would love feedback, tests or reviews.

Note: shell_check CI action is breaking due to diff size, will be ignored for merge.

Ralim avatar May 25 '24 13:05 Ralim