IronOS icon indicating copy to clipboard operation
IronOS copied to clipboard

graphics for S60/P & TS101

Open discip opened this issue 1 year ago • 13 comments

@Ralim Here you go. 😀

Tried to implement all the necessary graphics for S60/P & TS101.

I know this will not work until you do all the necessities around it. At least I hope the way I tried to implement this makes any sense. 😅

Not every graphic is pretty yet, but at least it should be testable.

Please let me know what you think.

menu animations
power Power
soldering Soldering
sleep Sleep
UI UI
advanced Advanced
statics
S60/P TS101
A-button A-button A-button
B-button B-button
missing tip missing tip missing tip
unavailable unavailable
bootlogo once once
loop loop

discip avatar Sep 22 '23 23:09 discip

@Ralim Don't know if you had a chance to observe the changed pics. I assume: Most likely not ! 😀 Anyway now there are attached gifs ...

Hope you like it.

discip avatar Sep 23 '23 20:09 discip

Amazing work, suppppppppeeerrrr appreciate it.

Haven't had a chance to test on hardware yet but when I get some downtime I will do some quick patching to get some of this in place asap 🤞

Thank you so much for this ❤️

Ralim avatar Sep 24 '23 01:09 Ralim

@Ralim What am I doing wrong here, why is it not compiling for the S60 Or the TS101? 🤷🏻‍♂️ Any idea?

Also https://github.com/Ralim/IronOS/discussions/1806#discussioncomment-7720404. 😁

discip avatar Dec 05 '23 22:12 discip

Unsure, might need to re-base on dev rather than merge. Not quite sure tbqh.

Ralim avatar Dec 05 '23 23:12 Ralim

@Ralim

Haven't had a chance to test on hardware yet but when I get some downtime I will do some quick patching to get some of this in place asap 🤞

Have you had time to test this in the mean time? Is this needed to be merged before #1749, or do you think it would be best to do this afterwards?

Also: Have you any advice for me about flashing my S60P with IronOS for S60? I'm still somewhat hesitant about doing it, due to the risk of bricking my precious S60P.

discip avatar Jan 14 '24 00:01 discip

One more thing about flashing the S60P: As long as I will not be able to flash IronOS, I will not be able to test if the graphics are working. 😅

discip avatar Jan 15 '24 21:01 discip

I follow the discussion

Jonny-T-cyber avatar Feb 01 '24 09:02 Jonny-T-cyber

Hello! I have TS101 solder and i am interested in your pull) How i can install your firmware?

dev0stranger avatar Feb 02 '24 23:02 dev0stranger

@dev0stranger This PR needs to be tested first. I don't own a TS101 so I couldn't do this.

discip avatar Feb 10 '24 17:02 discip

I somehow managed to compile your branch for my TS101 by rebasing your branch on the dev branch, but the icons are not being displayed correctly. I guess this is because support for bigger displays has not been added yet?

IMG_20240211_210201

brushmate avatar Feb 11 '24 20:02 brushmate

Hi! I'm waiting for the firmware for the TS101 to be completed so I can install it, in the meantime... where can I find the ORIGINAL firmware for the TS101 so I can go back in case of problems? Thanks

Jonny-T-cyber avatar Feb 12 '24 15:02 Jonny-T-cyber

@brushmate

I somehow managed to compile your branch for my TS101 by rebasing your branch on the dev branch, but the icons are not being displayed correctly. I guess this is because support for bigger displays has not been added yet?

As you may have noticed in your photo only a portion of the OLED but the individual graphics are intended for the whole screen. So we have to wait until the support for the entire OLED gets implemented.

discip avatar Feb 12 '24 17:02 discip

On my new TS101 I have firmware V2.04. While in the link you provided the latest version is V2.01 (which I had already found online). Has anyone found a link to version V2.04? Thanks

Jonny-T-cyber avatar Feb 12 '24 20:02 Jonny-T-cyber

Besides the graphics what else is needed? @Ralim

ArturoGuerra avatar Feb 28 '24 02:02 ArturoGuerra

This will be pulled in via the branch for splitting out rendering for different screen sizes. I'm slowly working on it as life allows me to.

Ralim avatar Feb 28 '24 02:02 Ralim

This will be pulled in via the branch for splitting out rendering for different screen sizes. I'm slowly working on it as life allows me to.

okay I'll have a look in a bit and see if I can help with that, also for the standardized power interface do you want to include all currently supported usb protocols so QC and USB-PD or just USB-PD?

ArturoGuerra avatar Feb 28 '24 03:02 ArturoGuerra

Once I finish splitting all the render/* functions out (in a day or two) I'll start a draft PR to track it. When that happens then basically need to update every single render function to layout on the larger screen correctly 😓

I only intend to implement PD for all devices going forward if I get any choice in it. QC is a dead standard and its a shit-show for compatibility as well. Much prefer only focusing on standards that are open and properly standardised.

Ralim avatar Feb 28 '24 04:02 Ralim

@Ralim Any news so far? 😊

discip avatar Mar 13 '24 20:03 discip

Any news so far? 😊

I've now pulled these into #1883, and will slowly be working over there to update all the drawing commands to draw the right size / location

Ralim avatar Mar 20 '24 22:03 Ralim

@Ralim Hey Ben, thank you for keeping this going. 😃👍

Could you please help finding the cause, why this doesn't compile for the S60P, but for the TS101 it does?

thanks in advance

discip avatar Apr 03 '24 10:04 discip

Could you please help finding the cause, why this doesn't compile for the S60P, but for the TS101 it does?

Hello.

It seems there is no declaration of ButtonA and related stuff in Font.h for S60P model explicitly. What's going on in Font.h is pure magic for me (I mean those constants), but apparently between all of these #ifdef MODEL / #else / #endif there is a missing conditional branch for macro pre-processor managing values of ButtonA and disconnectedTip.

Pre-processor goes here for S60P first, but then there is conditions like: #ifdef MODEL_S60
and
#elif defined MODEL_TS101
but there is no values of the variables for S60P, because there is no such condition for S60P to define related values.

Basically, since support for S60P has been implemented, now Font.h should be updated and ported to support for S60P.

Probably for fix you should make this line to look something like this: #if defined(MODEL_S60) || defined(MODEL_S60P) but I'm not 100% sure that the values from S60 variables will be valid for S60P model.

Hope it will help.

ia avatar Apr 03 '24 11:04 ia

Thank you very much for the effort you put into describing the issue so precisely!

#if defined(MODEL_S60) || defined(MODEL_S60P)

You are absolutely right. That's the line I missed. 🤦‍♂️

discip avatar Apr 03 '24 11:04 discip

Thank you very much for the effort you put into describing the issue so precisely!

#if defined(MODEL_S60) || defined(MODEL_S60P)

You are absolutely right. That's the line I missed. 🤦‍♂️

I just was happy to help with everything I can, as always. Glad it worked. :)

ia avatar Apr 03 '24 12:04 ia

This was implemented in #1888.

discip avatar Apr 09 '24 21:04 discip