whateverable icon indicating copy to clipboard operation
whateverable copied to clipboard

You could hang committable and benchable for a really long time by sleeping for the max timeout for the max number of commits

Open MasterDuke17 opened this issue 8 years ago • 6 comments

It would be good to have a timer around the loop that runs the code for each commit so we can bail out if the total time is taking too long, in addition to the alarm-based timeout for each individual run.

MasterDuke17 avatar Jul 27 '16 04:07 MasterDuke17

Performing the work in a non-blocking way would also help.

It's just a start keyword away in new and improved IRC::Client :smile_cat:

    use IRC::Client;
    .run with IRC::Client.new:
        :nick<MahBot>
        :host<irc.freenode.net>
        :channels<#perl6>
        :debug
        :plugins(class Bisectable { multi method irc-addressed ($e) { start do-bisection $e.text } })

zoffixznet avatar Jul 27 '16 10:07 zoffixznet

@zoffixznet we know :)

We are going to rewrite it in 6lang as soon as possible. Thank you for IRC::Client.

AlexDaniel avatar Jul 27 '16 14:07 AlexDaniel

And it looks like there's lots of work going on with IRC::Client, nice.

MasterDuke17 avatar Jul 27 '16 14:07 MasterDuke17

Fixed for committable and benchable in b19c8e2.

MasterDuke17 avatar Jul 30 '16 11:07 MasterDuke17

Fixed for committable6 and benchable6, bisectable(6) already have this capability.

MasterDuke17 avatar Aug 10 '16 23:08 MasterDuke17

Here's the list of all bots, mark anything that has a test already or if such tests don't apply for that bot:

  • [x] Bisectable
  • [x] Committable
  • [x] Benchable
  • [x] Evalable
  • [x] Statisfiable
  • [x] Unicodable
  • [ ] Bloatable
  • [ ] Quotable
  • [ ] Greppable
  • [x] Coverable
  • [x] Releasable
  • [x] Nativecallable
  • [x] Squashable
  • [x] Reportable
  • [x] Notable
  • [x] Shareable
  • [ ] Undersightable

AlexDaniel avatar Jun 02 '18 15:06 AlexDaniel