FallingTree icon indicating copy to clipboard operation
FallingTree copied to clipboard

Speed multiplicand doesn't work

Open Dr-WeiAL opened this issue 2 years ago • 8 comments

Describe the bug

When I set this configuration item to 1.0 or 2.0, nothing happens, it is exactly the same as when it is 0.0

Minecraft version

1.18.1

Fabric API version

0.46.4

Mod version

3.2.1

Relevant log output

latest.log

Dr-WeiAL avatar Mar 03 '22 19:03 Dr-WeiAL

I see you have quite some mods loaded. Can you reproduce it with only FallingTree?

If you can't then it's probably an incompatibility with one of those mods and you'll have to fine tune it down to know which one.

Rakambda avatar Mar 03 '22 19:03 Rakambda

I found out what the problem is, using it with Origins causes this problem

Dr-WeiAL avatar Mar 07 '22 12:03 Dr-WeiAL

So both FallingTree and Origins modifies the breaking speed.

FallingTree: https://github.com/RakSrinaNa/FallingTree/blob/1.18.2/fabric/src/main/java/fr/raksrinana/fallingtree/fabric/mixin/AbstractBlockMixin.java#L20

Origins: https://github.com/apace100/apoli/blob/master/src/main/java/io/github/apace100/apoli/mixin/AbstractBlockMixin.java#L25

Now both of those methods takes the previously returned value into account, so it should be fine. Unless Origins has one of the powers that overrides it and returns a fixed value. I don't know Origins enough to be able to tell that though. Seems like it's controlled by this power and may be defined in json files.

Rakambda avatar Mar 07 '22 13:03 Rakambda

I also don't understand very well, I didn't choose any race, this problem also occurs when using the default human

Dr-WeiAL avatar Mar 07 '22 13:03 Dr-WeiAL

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 10 '22 15:07 stale[bot]

If I remember correctly, the issue has been fixed

Dr-WeiAL avatar Jul 10 '22 15:07 Dr-WeiAL

Well, when I used fabric again, I found it didn't solve

Dr-WeiAL avatar Jul 11 '22 20:07 Dr-WeiAL

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 31 '22 09:07 stale[bot]