spitfire icon indicating copy to clipboard operation
spitfire copied to clipboard

fixes for running on older versions of .net and windows

Open Terricide opened this issue 6 years ago • 2 comments

Terricide avatar Jul 25 '18 21:07 Terricide

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mark Reed seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 25 '18 21:07 CLAassistant

I needed to comment out the following lines in WebRtcSession.cs to get the example working:

Spitfire.OnDataChannelConnecting += Spitfire_OnDataChannelConnecting;
Spitfire.OnDataChannelClosing += Spitfire_OnDataChannelClosing;
Spitfire.OnDataMessage += Spitfire_OnDataMessage;
Spitfire.OnDataBinaryMessage += Spitfire_OnDataBinaryMessage;

Also in Program.cs it may be more informative to change Console.WriteLine("Meesage from peer:" + ex); to Console.WriteLine("Meesage from peer:" + ex.Data);

But other than that this should really be merged in

gsidsid avatar May 19 '19 06:05 gsidsid