ecommerce icon indicating copy to clipboard operation
ecommerce copied to clipboard

Display Shipments

Open andrzejkrzywda opened this issue 3 years ago • 3 comments

Let's create a new menu item called "Shipments".

A list of those orders which have Shipment assigned will appear.

Probably we only need to react to "Shipment*" events. The output would be an ActiveRecord model ShipmentsList::Shipment with shipment_id/order_id, address, status.

andrzejkrzywda avatar Jun 28 '22 13:06 andrzejkrzywda

hey @andrzejkrzywda can I take this issue? Also if there are any other details kindly share.

saksham-jain avatar Jul 19 '22 06:07 saksham-jain

Go for it.

I'd recommend looking at other read models and follow the conventions.

andrzejkrzywda avatar Jul 19 '22 07:07 andrzejkrzywda

@andrzejkrzywda having some questions.

  • Address would be a combination of all 4 lines?
  • In the first column do we need to show the order name or order uid?
  • How to get the status of the shipment?

saksham-jain avatar Jul 19 '22 12:07 saksham-jain

  • yes
  • name sounds better, how do you think?
  • we now have only 2 states, Shipped or not Shipped (from the user perspective), I think ShipmentSubmitted is the fact which changes the state

andrzejkrzywda avatar Aug 17 '22 17:08 andrzejkrzywda

Okay, I still cannot figure out how to get shipment state. I will raise PR #176 having a shipment page without the state. Please guide me through how I can get state.

This is how the shipment page would look like Screenshot 2022-08-20 at 3 35 56 PM

saksham-jain avatar Aug 20 '22 10:08 saksham-jain

Thanks for the screenshot!

I understand the issue with displaying the state - let's remove it for now.

As for the link to order - we can extract it to another issue - I understand it's a bit more tricky.

andrzejkrzywda avatar Aug 20 '22 11:08 andrzejkrzywda

okay @andrzejkrzywda removed state column.

saksham-jain avatar Aug 20 '22 12:08 saksham-jain