rails_apps_composer icon indicating copy to clipboard operation
rails_apps_composer copied to clipboard

README.textile is not created if git is not in the recipes list

Open monfresh opened this issue 12 years ago • 2 comments

Steps to reproduce:

  1. mkdir rap-test-app

  2. cd rap-test-app

  3. rvm use ruby-2.0.0@rap-test-app --ruby-version --create

  4. gem install rails

  5. gem install rails_apps_composer

  6. rails_apps_composer new . -d /path/to/defaults.yml In my case, here is the defaults file I used: https://gist.github.com/monfresh/5663043

  7. Press return when you get: Which recipe would you like to add? (blank to finish)

  8. Press return when you get: What gem would you like to add? (blank to finish)

  9. Choose "n" for: extras Set a robots.txt file to ban spiders? (y/n)

  10. Choose "n" for: Create a GitHub repository? (y/n)

Expected Result: a README.textile is created Actual Result: README.textile is not created. Instead, a README is created with the following contents:

RECIPES
["controllers", "extras", "gems", "models", "readme", "routes", "setup", "testing", "views"]
PREFERENCES
{:dev_webserver=>"unicorn", :prod_webserver=>nil, :database=>"mongodb", :orm=>"mongoid", :unit_test=>"rspec", :templates=>"haml", :integration=>"none", :continuous_testing=>"guard", :fixtures=>"factory_girl", :authentication=>"none", :authorization=>"none", :form_builder=>"none", :starter_app=>"none", :local_env_file=>false, :quiet_assets=>true, :better_errors=>true, :rvmrc=>true, :email=>"none"}

and a README.rdoc is created with the following contents: https://gist.github.com/monfresh/5663004

In addition, there is a README_FOR_APP created in a "doc" folder, with the following contents:

Use this README file to introduce your application and point to useful places in the API for learning more.
Run "rake doc:app" to generate API documentation for your models, controllers, helpers, and libraries.

If the defaults.yml is modified to include git as a recipe, then README.textile is created, README_FOR_APP is not created, and the plain README now contains the following:

Rails3 Api Mongoid Rspec
========================

This application was generated with the rails_apps_composer gem:
https://github.com/RailsApps/rails_apps_composer
provided by the RailsApps Project:
http://railsapps.github.io/

________________________

Recipes:
["controllers", "extras", "gems", "git", "models", "readme", "routes", "setup", "testing", "views"]

Preferences:
{:dev_webserver=>"unicorn", :prod_webserver=>nil, :database=>"mongodb", :orm=>"mongoid", :unit_test=>"rspec", :templates=>"haml", :integration=>"none", :continuous_testing=>"guard", :fixtures=>"factory_girl", :authentication=>"none", :authorization=>"none", :form_builder=>"none", :starter_app=>"none", :local_env_file=>false, :quiet_assets=>true, :better_errors=>true, :rvmrc=>true, :git=>true, :email=>"none"}

________________________

License

monfresh avatar May 28 '13 14:05 monfresh

I can't reproduce this anymore after adding and removing git from the yml file. Perhaps there was a glitch in the yml that prevented RAP from realizing the readme recipe was present?

monfresh avatar May 28 '13 21:05 monfresh

This happened to me again after creating an app from a custom template that I created from a defaults file + custom recipes. I'll have to do some more testing to figure out what's going on.

monfresh avatar May 29 '13 02:05 monfresh