rails-omniauth icon indicating copy to clipboard operation
rails-omniauth copied to clipboard

Don't rescue Exception

Open artworx opened this issue 10 years ago • 0 comments

Fom application_controller

def current_user
      begin
        @current_user ||= User.find(session[:user_id]) if session[:user_id]
      rescue Exception => e
        nil
      end
    end

It is bad practice to rescue Exception, see http://stackoverflow.com/questions/10048173/why-is-it-bad-style-to-rescue-exception-e-in-ruby

artworx avatar Oct 22 '15 18:10 artworx